[Alsaplayer-devel] [PATCH] Fix getting JACK sample rate

Dominique Michel dominique.michel at citycable.ch
Wed Dec 5 19:58:38 GMT 2007


Le Wed, 5 Dec 2007 14:24:34 +0200,
Juuso Alasuutari <juuso.alasuutari at gmail.com> a écrit :

> Hi,
> 
> AlsaPlayer appears to rely on jack_set_sample_rate_callback() to get the JACK 
> sample rate. This function is deprecated in jackdmp, and thus AlsaPlayer will 
> get a 0 sample rate from jackdmp and the JACK output plugin will fail to run.
> 
> Deprecating jack_set_sample_rate_callback() may be a design flaw in jackdmp, 
> but the fact that AlsaPlayer works as it is with normal jackd may be mere 
> chance. As far as I know, the JACK server isn't guaranteed to call the sample 
> rate callback function when a client registers itself. AlsaPlayer should get 
> the JACK sample rate from calling jack_get_sample_rate(); here's a patch to 
> do just that.
> 
> Thanks,
> Juuso
> 

Thank you Juuso,

It work fine here and I just committed it. I guess that many JACK users will be
happy with your fix.

Cheers,
Dominique



More information about the alsaplayer-devel mailing list