[Alsaplayer-devel] Re: [Alsaplayer-commits] SF.net SVN: alsaplayer: [1243] trunk/alsaplayer/app/CorePlayer.cpp

[Hubert Chan]

On 2007-07-07 15:07:16 -0400 peter_lemenkov at users.sourceforge.net 
wrote:

> Revision: 1243
>           
> http://alsaplayer.svn.sourceforge.net/alsaplayer/?rev=1243&view=rev
> Author:   peter_lemenkov
> Date:     2007-07-07 12:07:16 -0700 (Sat, 07 Jul 2007)
> 
> Log Message:
> -----------
> Changed numeric value for maximum lenght of pathname to standart 
> macro-definition

While PATH_MAX is better than the hard-coded constant, PATH_MAX is not 
guaranteed to be defined (e.g. it is not defined on HURD).

Since CorePlayer.cpp is C++, it should be using C++-style strings 
instead of C-style strings anyways.  (There are a couple of potential 
buffer-overflows in that function, since it uses sprintf instead of 
snprintf.  Hmmm... maybe someone should audit all the sprintf 
calls...)

-- 
Hubert Chan - email & Jabber: hubert at uhoreg.ca - http://www.uhoreg.ca/
PGP/GnuPG key: 1024D/124B61FA   (Key available at wwwkeys.pgp.net)
Fingerprint: 96C5 012F 5F74 A5F7 1FF7  5291 AF29 C719 124B 61FA