[Alsaplayer-devel] Re: [Alsaplayer-commits] SF.net SVN: alsaplayer: [1243] trunk/alsaplayer/app/CorePlayer.cpp

[Dominique Michel]

Le Sat, 07 Jul 2007 16:20:22 -0400,
Hubert Chan <hubert at uhoreg.ca> a écrit :

> On 2007-07-07 15:07:16 -0400 peter_lemenkov at users.sourceforge.net 
> wrote:
> 
> > Revision: 1243
> >           
> > http://alsaplayer.svn.sourceforge.net/alsaplayer/?rev=1243&view=rev
> > Author:   peter_lemenkov
> > Date:     2007-07-07 12:07:16 -0700 (Sat, 07 Jul 2007)
> > 
> > Log Message:
> > -----------
> > Changed numeric value for maximum lenght of pathname to standart 
> > macro-definition
> 
> While PATH_MAX is better than the hard-coded constant, PATH_MAX is not 
> guaranteed to be defined (e.g. it is not defined on HURD).

I see at it is still in the svn after Peter reversing. I thing that we have
to put something in the INSTALL file about this. Is the following OK?

On HURD architecture, you have to export a PATH_MAX variable before compiling.
As example:
export PATH_MAX=1024

Dominique

> 
> Since CorePlayer.cpp is C++, it should be using C++-style strings 
> instead of C-style strings anyways.  (There are a couple of potential 
> buffer-overflows in that function, since it uses sprintf instead of 
> snprintf.  Hmmm... maybe someone should audit all the sprintf 
> calls...)
> 


-- 
Dominique Michel

--
N.B.: Tous les emails que je reçois sont filtrés par spamassassin avant de me
parvenir.