[Alsaplayer-devel] Re: [Alsaplayer-commits] SF.net SVN: alsaplayer: [1243] trunk/alsaplayer/app/CorePlayer.cpp

[Hubert Chan]

On 2007-07-08 06:19:45 -0400 Dominique Michel <dominique.michel at citycable.ch> wrote:

> Le Sat, 07 Jul 2007 16:20:22 -0400,
> Hubert Chan <hubert at uhoreg.ca> a écrit :
> 
>> While PATH_MAX is better than the hard-coded constant, PATH_MAX is not 
>> guaranteed to be defined (e.g. it is not defined on HURD).
> 
> I see at it is still in the svn after Peter reversing. I thing that we have
> to put something in the INSTALL file about this. Is the following OK?
> 
> On HURD architecture, you have to export a PATH_MAX variable before compiling.
> As example:
> export PATH_MAX=1024

It might be better to just rewrite the code as:

#ifdef PATHMAX
  char path[PATHMAX];
#else
  char path[1024];
#endif

-- 
Hubert Chan - email & Jabber: hubert at uhoreg.ca - http://www.uhoreg.ca/
PGP/GnuPG key: 1024D/124B61FA   (Key available at wwwkeys.pgp.net)
Fingerprint: 96C5 012F 5F74 A5F7 1FF7  5291 AF29 C719 124B 61FA