simon-git: putty (master): Simon Tatham

[Commits to Tartarus CVS repository.]

TL;DR:
  c269dd0 Move echo/edit state change functionality out of ldisc_send.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2014-11-22 16:25:24

commit c269dd0135a927d4d22a334cfefb09361f311fcd
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=c269dd0135a927d4d22a334cfefb09361f311fcd;hp=d870b5650e48eb04529e8f8d8e9f73ca9923b3a1
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 22 16:12:47 2014 +0000

    Move echo/edit state change functionality out of ldisc_send.
    
    I'm not actually sure why we've always had back ends notify ldisc of
    changes to echo/edit settings by giving ldisc_send(ldisc,NULL,0,0) a
    special meaning, instead of by having a separate dedicated notify
    function with its own prototype and parameter set. Coverity's recent
    observation that the two kinds of call don't even have the same
    requirements on the ldisc (particularly, whether ldisc->term can be
    NULL) makes me realise that it's really high time I separated the two
    conceptually different operations into actually different functions.
    
    While I'm here, I've renamed the confusing ldisc_update() function
    which that special operation ends up feeding to, because it's not
    actually a function applying to an ldisc - it applies to a front end.
    So ldisc_send(ldisc,NULL,0,0) is now ldisc_echoedit_update(ldisc), and
    that in turn figures out the current echo/edit settings before passing
    them on to frontend_echoedit_update(). I think that should be clearer.

 ldisc.c            |   23 +++++++----------------
 macosx/osxwin.m    |    2 +-
 pscp.c             |   11 +----------
 psftp.c            |   11 +----------
 putty.h            |    3 ++-
 ssh.c              |    4 ++--
 telnet.c           |    2 +-
 terminal.c         |    8 ++++----
 unix/gtkwin.c      |    8 ++++----
 unix/uxplink.c     |    9 +++++----
 windows/window.c   |    6 +++---
 windows/winplink.c |    2 +-
 12 files changed, 32 insertions(+), 57 deletions(-)