simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  07f99e6e Remove 'defused' parameter from wc_to_mb.
  e6550539 Add a couple of missing 'static' qualifiers.
  d9369d4a Give PuTTYtel its own Windows manifest file.
  6c0f22bb Give fxp_mkdir_send an attrs parameter.
  62f630d4 cygtermd: remove all uses of 'FIXME' as program name.
  0bbe87f1 Rewrite some comments with FIXMEs in them.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-10-06 12:08:01

commit 07f99e6e82deede236e2ef3aae64537220c3c89f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=07f99e6e82deede236e2ef3aae64537220c3c89f;hp=461ade43d1d3107a674f79b94966de84ff577d2b
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 6 11:45:26 2018 +0100

    Remove 'defused' parameter from wc_to_mb.
    
    It's never set to anything but NULL at any call site, and there's been
    a FIXME comment in uxucs.c for ages saying it should be removed. I
    think it only existed in the first place because it was a facility
    supported by the underlying Windows API function and we couldn't see a
    reason _not_ to pass it through. But I'm cleaning up FIXMEs, so we
    should get rid of it.
    
    (It stood for 'default used', incidentally - as in 'did the function
    at any point have to make use of the parameter providing a default
    fallback character?'. Nothing to do with _defusing_ things :-)

 ldiscucs.c       | 2 +-
 putty.h          | 2 +-
 unix/gtkfont.c   | 6 +++---
 unix/gtkwin.c    | 2 +-
 unix/uxucs.c     | 6 +-----
 windows/winucs.c | 9 +++++----
 6 files changed, 12 insertions(+), 15 deletions(-)

commit e655053942b788d63513def4ba4d92dd9f396675
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=e655053942b788d63513def4ba4d92dd9f396675;hp=07f99e6e82deede236e2ef3aae64537220c3c89f
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 6 11:46:37 2018 +0100

    Add a couple of missing 'static' qualifiers.

 unix/uxstore.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit d9369d4a46c40c3c4cd8108fea9d64ee69fbd041
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d9369d4a46c40c3c4cd8108fea9d64ee69fbd041;hp=e655053942b788d63513def4ba4d92dd9f396675
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 6 11:49:09 2018 +0100

    Give PuTTYtel its own Windows manifest file.
    
    While grepping for FIXME comments I could get rid of easily, I came
    across a completely unexplained one in puttytel.rc, and after a moment
    of thought, realised that it was there because PuTTYtel sharing
    PuTTY's manifest file means the manifest has the wrong application
    name.
    
    Of course I could do something a bit more clever involving having one
    copy of the manifest file and templating it to multiple applications,
    but I think it would be more pain than it's worth given that the
    templating system would have to be compatible with all the makefiles
    and run on Windows systems where no sensible scripting was available.
    So I just do it the trivial way.

 windows/puttytel.mft | 31 +++++++++++++++++++++++++++++++
 windows/puttytel.rc  |  3 +--
 2 files changed, 32 insertions(+), 2 deletions(-)

commit 6c0f22bb9fe9c0e1dd8763327b02ca5d1693a59e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=6c0f22bb9fe9c0e1dd8763327b02ca5d1693a59e;hp=d9369d4a46c40c3c4cd8108fea9d64ee69fbd041
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 6 11:52:04 2018 +0100

    Give fxp_mkdir_send an attrs parameter.
    
    It's not used anywhere, but this would make it one step easier to add
    a mode argument to PSFTP's mkdir command, if anyone needs it. Mostly
    the point is to get rid of the FIXME comment in fxp_mkdir_send itself.

 pscp.c  |  2 +-
 psftp.c |  4 ++--
 sftp.c  | 14 +++++++-------
 sftp.h  |  5 +++--
 4 files changed, 13 insertions(+), 12 deletions(-)

commit 62f630d4b30c2bcea0c6c908496ed063cecd48a2
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=62f630d4b30c2bcea0c6c908496ed063cecd48a2;hp=6c0f22bb9fe9c0e1dd8763327b02ca5d1693a59e
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 6 11:55:56 2018 +0100

    cygtermd: remove all uses of 'FIXME' as program name.
    
    There was a while when I hadn't decided what the name of the program
    was going to be, and apparently once I did I never got round to
    substituting it back in everywhere.

 contrib/cygtermd/main.c   | 2 +-
 contrib/cygtermd/pty.h    | 6 +++---
 contrib/cygtermd/sel.h    | 6 +++---
 contrib/cygtermd/telnet.h | 6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)

commit 0bbe87f11e1fdc6d62a49405018fb2b1e76b88f6
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=0bbe87f11e1fdc6d62a49405018fb2b1e76b88f6;hp=62f630d4b30c2bcea0c6c908496ed063cecd48a2
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 6 11:46:47 2018 +0100

    Rewrite some comments with FIXMEs in them.
    
    These are things where no fix was actually necessary in the code, but
    the FIXME indicated that the comment itself was either in need of a
    rewrite or removal.

 contrib/cygtermd/pty.h |  2 +-
 unix/uxstore.c         | 26 ++++++++++++++++++--------
 windows/version.rc2    |  9 ++++++---
 windows/win_res.rc2    | 10 +++++++---
 4 files changed, 32 insertions(+), 15 deletions(-)