simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  d624ae2a Fix double-free bug in (non-EC) Diffie-Hellman.
  a3a8b285 Tidy up 'eventlog_stuff' structure and fix leak.
  78d0022c settings.c: replace some 'void *' with proper types.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-10-08 19:40:14

commit d624ae2ab5090c1c14db2b329df1cd4eb71db621
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d624ae2ab5090c1c14db2b329df1cd4eb71db621;hp=e3e434537da5e0a42fed71b9c684f1f5176cb726
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Oct 8 19:25:57 2018 +0100

    Fix double-free bug in (non-EC) Diffie-Hellman.
    
    The variable s->e in ssh2_transport_state should never be freed by
    ssh2transport itself, because it's owned by the dh_ctx, so it will be
    freed by dh_cleanup.

 ssh2transport.c | 3 ---
 1 file changed, 3 deletions(-)

commit a3a8b285287772b6d7c2f0870dfd3694d5d879d4
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=a3a8b285287772b6d7c2f0870dfd3694d5d879d4;hp=d624ae2ab5090c1c14db2b329df1cd4eb71db621
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Oct 8 19:30:01 2018 +0100

    Tidy up 'eventlog_stuff' structure and fix leak.
    
    This is the structure that stores the truncated version of the Event
    Log data to be displayed by the GTK Event Log dialog. It persists for
    the lifetime of the parent SSH window, so it was deliberate that it
    wasn't freed on destruction of the dialog itself, but I also forgot to
    free it on destruction of the SSH window. (This will be more important
    in multi-connection process architectures like the OS X port, of
    course.)
    
    While I'm at it, I'll follow my recent practice by exposing the
    structure tag outside gtkdlg.c so that callers can more easily not
    confuse it with some other kind of void *.

 unix/gtkdlg.c | 37 ++++++++++++++++++++++++++-----------
 unix/gtkwin.c |  4 +++-
 unix/unix.h   |  8 +++++---
 3 files changed, 34 insertions(+), 15 deletions(-)

commit 78d0022c707b3dffa2514fe842be04224213da73
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=78d0022c707b3dffa2514fe842be04224213da73;hp=a3a8b285287772b6d7c2f0870dfd3694d5d879d4
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Oct 8 19:35:58 2018 +0100

    settings.c: replace some 'void *' with proper types.
    
    Commit 733fcca2c introduced named types settings_r and settings_w and
    made the per-platform storage abstraction use those in place of 'void
    *'. But a lot of the intermediate helper functions in the centralised
    settings.c, like gpps() and wmap(), were still taking 'void *'. It
    still worked, because of C's implicit casting, but it was avoiding the
    type-checking advantages from making that change in the first place.

 settings.c | 55 +++++++++++++++++++++++++++++--------------------------
 1 file changed, 29 insertions(+), 26 deletions(-)