simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sun Jan 13 20:01:02 GMT 2019


TL;DR:
  ced0f191 Ensure our aes_ni_context is 16-byte aligned.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-01-13 20:01:02

commit ced0f1911830eceae26c737e93b44136828f2f13
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=ced0f1911830eceae26c737e93b44136828f2f13;hp=2edae0d9d6892ac92554210aaa7f69573c9e3815
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Jan 13 20:00:53 2019 +0000

    Ensure our aes_ni_context is 16-byte aligned.
    
    The 32-bit x86 Windows build can crash with an alignment fault the
    first time it tries to write into the key schedule array, because it
    turns out that the x86 VS C library's malloc doesn't guarantee 16-byte
    alignment on the returned block even though there is a machine type
    that needs it.
    
    To avoid having to faff with non-portable library APIs, I solve the
    problem locally in aes_hw_new, by over-allocating enough to guarantee
    that an aligned block of the right size must exist somewhere in the
    region.

 sshaes.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list