simon-git: putty (main): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Tue Feb 2 18:26:47 GMT 2021
TL;DR:
9e1ec093 testcrypt: fix fake class methods on MACs.
af278ac8 Unix Plink: fix tight loop after EOF on stdin.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer: Simon Tatham <anakin at pobox.com>
Date: 2021-02-02 18:26:46
commit 9e1ec093fda3c071e4291a942b90c657945602a7
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=9e1ec093fda3c071e4291a942b90c657945602a7;hp=d851df486f066b37078fde6e99e775fa0b34fa02
Author: Simon Tatham <anakin at pobox.com>
Date: Tue Feb 2 18:17:46 2021 +0000
testcrypt: fix fake class methods on MACs.
I had the wrong function name prefix in the method_prefixes array: the
MAC functions all begin with ssh2_mac_* instead of ssh_mac_*. As a
result, MAC objects in the Python testcrypt system didn't provide
OO-like methods such as m.update() and m.genresult(); instead you had
to say ssh2_mac_update(m, ...) and ssh2_mac_genresult(m).
test/testcrypt.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit af278ac870c634f9f38b1ae2461b7ad580a4da1d
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=af278ac870c634f9f38b1ae2461b7ad580a4da1d;hp=9e1ec093fda3c071e4291a942b90c657945602a7
Author: Simon Tatham <anakin at pobox.com>
Date: Tue Feb 2 18:19:56 2021 +0000
Unix Plink: fix tight loop after EOF on stdin.
When Plink saw EOF on stdin, it would continue to put stdin in its
list of poll fds, so that the poll loop would always terminate
instantly with stdin readable. Plink would read from it, see EOF
again, go back to the poll loop, and keep spinning like that.
This was supposed to be fixed by the 'sending' flag, which was set to
false on seeing EOF to indicate that we were no longer interested in
reading stdin data to send to the SSH server. But that flag was
ineffective, because it turns out it was _always_ set to false -
nothing in the code ever set it to true! And the reason why that
didn't totally prevent reading from stdin at all is because it was
also tested with the wrong sense. How embarrassing.
Changed the flag name to 'seen_stdin_eof', and made it behave
sensibly.
unix/uxplink.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
More information about the tartarus-commits
mailing list