simon-git: puzzles (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Mon Sep 13 11:20:31 BST 2021


TL;DR:
  88358f0 Add 'const' to the draw_polygon coords array parameter.
  42cbd76 Add missing documentation of 'int dir' parameters.

Repository:     https://git.tartarus.org/simon/puzzles.git
On the web:     https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-09-13 11:20:31

commit 88358f064351e867c73e46783a239265ff9fef7a
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=88358f064351e867c73e46783a239265ff9fef7a;hp=d204978391141a68b338732ce24271402392534f
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Sep 13 11:04:59 2021 +0100

    Add 'const' to the draw_polygon coords array parameter.
    
    Thanks to Mouse for spotting that it was missing.

 devel.but | 4 ++--
 drawing.c | 2 +-
 gtk.c     | 6 +++---
 nullfe.c  | 2 +-
 osx.m     | 2 +-
 ps.c      | 2 +-
 puzzles.h | 4 ++--
 windows.c | 2 +-
 8 files changed, 12 insertions(+), 12 deletions(-)

commit 42cbd7688a7f05e0a5d56a603a04293307c1e1b2
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=42cbd7688a7f05e0a5d56a603a04293307c1e1b2;hp=88358f064351e867c73e46783a239265ff9fef7a
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Sep 13 11:09:54 2021 +0100

    Add missing documentation of 'int dir' parameters.
    
    This integer parameter appears in all of the game's anim_length,
    flash_length and redraw methods, but the documentation only described
    it properly in the section for anim_length.
    
    The section for flash_length refers you to anim_length for the
    description of all the parameters, but unhelpfully, it did so without
    a conveniently clickable (in HTML) cross-reference.
    
    And the section for game_redraw missed out the description of 'int
    dir' completely, which is particularly unhelpful since that's the
    function most likely to actually need to care about it! (Even if
    forward and reversed move animations look different, they _probably_
    still have the same duration, so it's more likely that anim_length
    would ignore 'dir' and redraw would use it than vice versa.)

 devel.but | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)



More information about the tartarus-commits mailing list