simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  18cac59b split_into_argv.c: tidy up large comment.
  6b1154cc Remove ldisc.h.
  0b099b6a Non-SSH network backends: handle PLUGLOG_CONNECT_SUCCESS.
  64f19209 Telnet: remove tabs from Event Log entries.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-09-13 13:44:41

commit 18cac59b433a45520dee290c683035b1fffd0d24
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=18cac59b433a45520dee290c683035b1fffd0d24;hp=8df3ad6316ccbd8600ede97b72a02daea3543fe7
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Sep 13 11:57:21 2021 +0100

    split_into_argv.c: tidy up large comment.
    
    I just happened to notice that just below my huge comment explaining
    the two command-line splitting policies, there's a smaller one that
    refers to it as '(see large comment below)'. It's not below - it's
    above!
    
    That was because the older parts of that comment had previously been
    inside split_into_argv(), until I moved the explanation further up the
    file to the top level. Another consequence of that was that the older
    section of the comment was wrapped to a strangely narrow line width,
    because it had previously been indented further right.
    
    Folded the two comments together, and rewrapped the narrow paragraphs.

 windows/utils/split_into_argv.c | 75 ++++++++++++++++++++++-------------------
 1 file changed, 40 insertions(+), 35 deletions(-)

commit 6b1154cc5b90181b7bd6c493bbb01d356b993077
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=6b1154cc5b90181b7bd6c493bbb01d356b993077;hp=18cac59b433a45520dee290c683035b1fffd0d24
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Sep 13 10:14:33 2021 +0100

    Remove ldisc.h.
    
    It only had to be a header file because ldisc.c and ldiscucs.c had to
    share the structure definition. But ldiscucs.c vanished a couple of
    years ago in commit 71e42b04a57479f, so it's now fine to make the
    Ldisc structure definition local to ldisc.c itself, the way it should
    be.

 ldisc.c | 17 ++++++++++++++++-
 ldisc.h | 27 ---------------------------
 2 files changed, 16 insertions(+), 28 deletions(-)

commit 0b099b6a6fb5725a1cb7cda013697bf7193cc81d
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=0b099b6a6fb5725a1cb7cda013697bf7193cc81d;hp=6b1154cc5b90181b7bd6c493bbb01d356b993077
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Sep 13 12:00:01 2021 +0100

    Non-SSH network backends: handle PLUGLOG_CONNECT_SUCCESS.
    
    All four of the other network-protocol backends (Raw, Telnet, rlogin
    and SUPDUP) now have a 'socket_connected' flag, which starts off false
    and is set to true when (if) their Socket signals that the connection
    attempt has succeeded.
    
    This field is used to tell backend_socket_log whether the session has
    started yet (hence, whether it should still be logging messages from
    the proxy). This replaces various ad-hoc answers to that question in
    each backend, which were the best I could do when sockets didn't
    notify connection success. Now they do, we can do it properly.
    
    Also, the new flag controls the answer to each backend's sendok()
    method, which makes them all satisfy a new policy rule: no backend
    shall return true from sendok() while its network connection attempt
    is still ongoing.
    
    (Rationale: the network connection attempt may in future involve a
    proxy implementation interacting with the user via the terminal, and
    it can't do that if the backend is already consuming all the terminal
    input.)

 otherbackends/raw.c    | 16 ++++++++--------
 otherbackends/rlogin.c | 10 +++++++---
 otherbackends/supdup.c |  9 +++++++--
 otherbackends/telnet.c | 13 +++++++------
 putty.h                |  9 ++++++++-
 5 files changed, 37 insertions(+), 20 deletions(-)

commit 64f192093a0eaa94066042936ce637259fd6d047
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=64f192093a0eaa94066042936ce637259fd6d047;hp=0b099b6a6fb5725a1cb7cda013697bf7193cc81d
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Sep 13 13:13:07 2021 +0100

    Telnet: remove tabs from Event Log entries.
    
    While re-testing the other backends, I noticed that they work really
    badly in the GTK event log, which apparently interprets tabs as
    meaning 'next table column', and assumes that any line not containing
    a tab must be entirely in the leftmost column. So all the Telnet
    negotiations are miles off to the right, beyond the longest other line
    in the entire log.
    
    Replaced with a bit more verbiage.

 otherbackends/telnet.c | 32 +++++++++++++++++++-------------
 1 file changed, 19 insertions(+), 13 deletions(-)