simon-git: puzzles (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  a11ee53 Keen, Solo, Towers, Undead, Unequal, Group: new UI preference.
  df31bc7 Group: make keyboard play work again.

Repository:     https://git.tartarus.org/simon/puzzles.git
On the web:     https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2023-08-13 14:41:04

commit a11ee53ef844522b48b06ddffed268fa86d7b2ec
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=a11ee53ef844522b48b06ddffed268fa86d7b2ec;hp=503f1c4ab81928c2792a2cf73bc97587460dac86
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Aug 13 14:03:26 2023 +0100

    Keen, Solo, Towers, Undead, Unequal, Group: new UI preference.
    
    If you're using the mouse to change pencil marks, you have to
    right-click to pencil-highlight a square, then press a number or
    letter key to add or remove a highlight. That causes the highlight to
    vanish again. So adding or removing multiple pencil marks requires a
    right-click + keypress per mark.
    
    Chris's Android port reversed that decision, making the pencil
    highlight persist so that you could 'click' just once and then press
    multiple pencil keys. That makes it easier to add lots of highlights,
    but harder to just remove a single one (click + press + click to
    remove the highlight), unless you don't mind keeping the highlight
    around afterwards cluttering up your view.
    
    In other words, this is just the sort of thing users might reasonably
    disagree on. So now we have an organised preferences system, we can
    let them disagree, and each configure it whichever way they like!
    
    This only affects mouse-based play. The keyboard cursor has _always_
    worked this way, because it doesn't disappear at all; its behaviour is
    unchanged, and independent of the new preference.

 keen.c             | 46 +++++++++++++++++++++++++++--
 solo.c             | 46 +++++++++++++++++++++++++++--
 towers.c           | 47 +++++++++++++++++++++++-------
 undead.c           | 85 ++++++++++++++++++++++++++++++++----------------------
 unequal.c          | 46 +++++++++++++++++++++++++++--
 unfinished/group.c | 46 +++++++++++++++++++++++++++--
 6 files changed, 262 insertions(+), 54 deletions(-)

commit df31bc7a515a56b2322a097bda8f1aa510a7b9da
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=df31bc7a515a56b2322a097bda8f1aa510a7b9da;hp=a11ee53ef844522b48b06ddffed268fa86d7b2ec
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Aug 13 14:31:50 2023 +0100

    Group: make keyboard play work again.
    
    It looks as if it's been broken for about nine years, ever since
    commit 822243de1bc1fc6d introduced the system for drag-selecting a
    diagonal of squares. The effect of moving the keyboard cursor and then
    pressing a button was to cause crashes because the ui fields
    introduced for that system to use (ohx, ohy, odx, ody, odn) were all
    completely uninitialised.

 unfinished/group.c | 4 ++++
 1 file changed, 4 insertions(+)