simon-git: puzzles (main): Ben Harris
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Mon Feb 20 00:33:58 GMT 2023
TL;DR:
1470c95 Try to stop CMake disabling assertions in release builds
1880feb Support multiple COMPILE_DEFINITIONS for a program
1235f05 Make the HAVE_HF_ITER define target-specific
Repository: https://git.tartarus.org/simon/puzzles.git
On the web: https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: main
Committer: Ben Harris <bjh21 at bjh21.me.uk>
Date: 2023-02-20 00:33:58
commit 1470c9530b1cff33d11170b9b891d94be62c4194
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=1470c9530b1cff33d11170b9b891d94be62c4194;hp=bb16b5a70ddf77d03f1e985cb761ad5aa6c19b2c
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date: Sun Feb 19 23:20:29 2023 +0000
Try to stop CMake disabling assertions in release builds
Assertion failures are ugly, but they're better than the alternative.
Defensive coding is a general principle throughout Puzzles and I don't
think it's sensible to selectively turn that off.
The mechanism by which we re-enable assertions is stolen from PuTTY
(with an enhancement to cover MinSizeRel builds as well) and is pretty
ugly because CMake doesn't seem to have a good way to do it.
cmake/setup.cmake | 10 ++++++++++
1 file changed, 10 insertions(+)
commit 1880feb442c4b2d73137b02c8dc58f8d38f4e16a
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=1880feb442c4b2d73137b02c8dc58f8d38f4e16a;hp=1470c9530b1cff33d11170b9b891d94be62c4194
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date: Mon Feb 20 00:28:42 2023 +0000
Support multiple COMPILE_DEFINITIONS for a program
Despite the name, COMPILE_DEFINITIONS was only ever used to set a
single definition, and as far as I can tell that's all it could do
even when I tried to put them in a single word separated by
semicolons. Turning COMPILE_DEFINITIONS into a multi-valued argument
seems to make it work much better.
cmake/setup.cmake | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 1235f05af70c3acea7eedb0cbfd726ab4ec357c4
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=1235f05af70c3acea7eedb0cbfd726ab4ec357c4;hp=1880feb442c4b2d73137b02c8dc58f8d38f4e16a
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date: Mon Feb 20 00:33:42 2023 +0000
Make the HAVE_HF_ITER define target-specific
Leaking HAVE_HF_ITER into the entire build just because fuzzpuzz
wanted it was ugly, and also this needs fewer lines of CMake code.
CMakeLists.txt | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
More information about the tartarus-commits
mailing list