[Snowball-discuss] Problems with -Wall flag

[Olly Betts]

On Tue, Feb 24, 2004 at 04:19:42PM -0700, Neal Richter wrote:
> compiler/space.c   ---- Fixes "int format, pointer arg" warning
> Line 58: if (DEBUG) printf("<-- %d\n", (unsigned int)p);
> Line 69: if (DEBUG) printf("--> %d\n", (unsigned int)p);
> Line 75: if (DEBUG) printf("%d --> %d\n", (unsigned int)p, (unsigned int)q);

Using %p is a better fix for this than adding casts.

> I also get these errors in the C code generated:

Coding standards are for humans.  Insisting machine-generated code
conforms to coding standards is foolish - the fact that Snowball
compiles via C is really just an implementation detail (like the
fact GCC compiles to machine code via assembly language - does
your organisation insist that the assembly code GCC generates
meets your coding standards?)

Cheers,
  Olly