Tartarus CVS: putty: simon

Sat, 07 Feb 2004 10:02:22 +0000

CVS Root:       /home/cvs
Module:         putty
Changes by:     simon
Date:           Sat Feb 07 2004  10:02:22 GMT

Log message:
Charles Wilcox reported a signature validation bug with 2500-bit RSA
keys. This _appears_ to be due to me computing the byte count of the
key by dividing the bit count by 8 and rounding _down_ rather than
up. Therefore, I can't see how this code could ever have worked on
any SSH2 RSA key whose length was not a multiple of 8 bits; and
therefore I'm staggered that we haven't noticed it before! OpenSSH's
keygen appears to be scrupulous about ensuring the returned key
length is exactly what you asked for rather than one bit less, but
even so I'm astonished that _all_ keygen implementations for servers
we've ever interoperated with have avoided tripping this bug...

Modified files:
    .               : sshrsa.c

Links:
http://cvs.tartarus.org//putty/sshrsa.c.diff?r1=1.38&r2=1.39