simon-svn: putty putty-wishlist: jacob

tartarus-commits at lists.tartarus.org tartarus-commits at lists.tartarus.org
Sun Oct 30 20:24:12 GMT 2005


SVN root:       svn://ixion.tartarus.org/main
Changes by:     jacob
Revision:       6437
Date:           2005-10-30 20:24:09 +0000 (Sun, 30 Oct 2005)

Log message (22 lines):
Revamp SSH authentication code so that user interaction is more
abstracted out; replace loops structured around a single interaction
per loop with less tortuous code (fixes: `ki-multiprompt-crash',
`ssh1-bad-passphrase-crash'; makes `ssh2-password-expiry' and
`proxy-password-prompt' easier).

The new interaction abstraction has a lot of fields that are unused in
the current code (things like window captions); this is groundwork for
`gui-auth'. However, ssh.c still writes directly to stderr; that may
want to be fixed.

In the GUI apps, user interaction is moved to terminal.c. This should
make it easier to fix things like UTF-8 username entry, although I
haven't attempted to do so. Also, control character filtering can be
tailored to be appropriate for individual front-ends; so far I don't
promise anything other than not having made it any worse.

I've tried to test this fairly exhaustively (although Mac stuff is
untested, as usual). It all seems to basically work, but I bet there
are new bugs. (One I know about is that you can no longer make the
PuTTY window go away with a ^D at the password prompt; this should be
fixed.)

Modified files:
U   putty/cmdgen.c
U   putty/cmdline.c
U   putty/mac/macterm.c
U   putty/macosx/osxwin.m
U   putty/misc.c
U   putty/pscp.c
U   putty/psftp.c
U   putty/putty.h
U   putty/ssh.c
U   putty/terminal.c
U   putty/unix/gtkwin.c
U   putty/unix/uxcons.c
U   putty/unix/uxplink.c
U   putty/unix/uxsftp.c
U   putty/windows/wincons.c
U   putty/windows/window.c
U   putty/windows/winplink.c
U   putty/windows/winsftp.c
U   putty-wishlist/data/ki-multiprompt-crash
U   putty-wishlist/data/ssh1-bad-passphrase-crash

Links:
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi?rev=6437&view=rev
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/cmdgen.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/cmdline.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/mac/macterm.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/macosx/osxwin.m?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/misc.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/pscp.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/psftp.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/putty.h?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/ssh.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/terminal.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/unix/gtkwin.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/unix/uxcons.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/unix/uxplink.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/unix/uxsftp.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/wincons.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/window.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/winplink.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/winsftp.c?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty-wishlist/data/ki-multiprompt-crash?rev=6437&r1=6436&r2=6437
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty-wishlist/data/ssh1-bad-passphrase-crash?rev=6437&r1=6436&r2=6437



More information about the tartarus-commits mailing list