simon-svn: putty: simon

[tartarus-commits at lists.tartarus.org]

SVN root:       svn://ixion.tartarus.org/main
Changes by:     simon
Revision:       6833
Date:           2006-08-29 19:32:44 +0100 (Tue, 29 Aug 2006)

Log message (10 lines):
The Windows HANDLE type, despite being a `void *', does not actually
behave like a pointer. In particular, the right thing to set a
HANDLE to to indicate that it's invalid is INVALID_HANDLE_VALUE, not
NULL. Crack down on sloppy use of NULL HANDLEs across all Windows
code.

(There is one oddity, which is that {Create,Open}FileMapping are
documented to return a NULL HANDLE instead of INVALID_HANDLE_VALUE
on failure. Shrug. If MS want to be inconsistent, I suppose I have
to live with it.)

Modified files:
U   putty/windows/window.c
U   putty/windows/winpgntc.c
U   putty/windows/winser.c
U   putty/windows/winsftp.c

Links:
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi?rev=6833&view=rev
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/window.c?rev=6833&r1=6832&r2=6833
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/winpgntc.c?rev=6833&r1=6832&r2=6833
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/winser.c?rev=6833&r1=6832&r2=6833
http://www.tartarus.org/~simon-anonsvn/viewcvs.cgi/putty/windows/winsftp.c?rev=6833&r1=6832&r2=6833