simon-svn: putty: simon

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Mon Dec 17 08:40:33 GMT 2012


SVN root:       svn://svn.tartarus.org/sgt
Changes by:     simon
Revision:       9726
Date:           2012-12-17 08:40:33 +0000 (Mon, 17 Dec 2012)

Log message (10 lines):
Add a bounds check in the word-by-word selection code to prevent
attempting to call lineptr() with a y-coordinate off the bottom of the
screen and triggering the dreaded 'line==NULL' message box.

This crash can only occur if the bottommost line of the screen has the
LATTR_WRAPPED flag set, which as far as I can see you can only
contrive by constructing a LATTR_WRAPPED line further up the screen
and then moving it down using an insert-line escape sequence. That's
probably why this bug has been around forever without anyone coming
across it.

Modified files:
U   putty/terminal.c

Links:
http://svn.tartarus.org/sgt/?rev=9726&view=rev
http://svn.tartarus.org/sgt/putty/terminal.c?rev=9726&r1=9725&r2=9726



More information about the tartarus-commits mailing list