simon-git: spigot (master): Simon Tatham

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Sun Dec 28 12:14:30 GMT 2014


TL;DR:
  6efe287 Fix logic error in Algebraic::clone().

Repository:     git://git.tartarus.org/simon/spigot.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=spigot.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2014-12-28 12:14:30

commit 6efe2876968f9c9e5f171024e0168726c52f0f38
web diff http://tartarus.org/~simon-git/gitweb/?p=spigot.git;a=commitdiff;h=6efe2876968f9c9e5f171024e0168726c52f0f38;hp=52364e08da65e517a2508d5ca9f80431b4c51ff7
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Dec 28 12:11:39 2014 +0000

    Fix logic error in Algebraic::clone().
    
    The clone method is always supposed to produce an object that can be
    re-evaluated from the beginning, even if computation has already
    commenced. Hence, since we evolve our polynomial throughout
    computation, we must keep a copy of the original version too, in case
    clone() is called.
    
    I wasn't actually able to find anywhere in the program where a clone
    method _is_ called after computation has commenced on the source
    object, so there's no actual failure I can trace to this bug. But it's
    a bug nonetheless.

 algebraic.cpp |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)



More information about the tartarus-commits mailing list