simon-svn: putty: simon

[Commits to Tartarus CVS repository.]

SVN root:       svn://svn.tartarus.org/sgt
Changes by:     simon
Revision:       10200
Date:           2014-07-06 15:05:39 +0100 (Sun, 06 Jul 2014)

Log message (15 lines):
Implement this year's consensus on CHANNEL_FAILURE vs CHANNEL_CLOSE.

We now expect that after the server has sent us CHANNEL_CLOSE, we
should not expect to see any replies to our outstanding channel
requests, and conversely after we have sent CHANNEL_CLOSE we avoid
sending any reply to channel requests from the server. This was the
consensus among implementors discussing the problem on ietf-ssh in
April 2014.

To cope with current OpenSSH's (and perhaps other servers we don't
know about yet) willingness to send request replies after
CHANNEL_CLOSE, I introduce a bug-compatibility flag which is detected
for every OpenSSH version up to and including the current 6.6 - but
not beyond, since https://bugzilla.mindrot.org/show_bug.cgi?id=1818
promises that 6.7 will also implement the new consensus behaviour.

Modified files:
U   putty/config.c
U   putty/doc/config.but
U   putty/putty.h
U   putty/settings.c
U   putty/ssh.c
U   putty/windows/winhelp.h

Links:
http://svn.tartarus.org/sgt/?rev=10200&view=rev
http://svn.tartarus.org/sgt/putty/config.c?rev=10200&r1=10199&r2=10200
http://svn.tartarus.org/sgt/putty/doc/config.but?rev=10200&r1=10199&r2=10200
http://svn.tartarus.org/sgt/putty/putty.h?rev=10200&r1=10199&r2=10200
http://svn.tartarus.org/sgt/putty/settings.c?rev=10200&r1=10199&r2=10200
http://svn.tartarus.org/sgt/putty/ssh.c?rev=10200&r1=10199&r2=10200
http://svn.tartarus.org/sgt/putty/windows/winhelp.h?rev=10200&r1=10199&r2=10200