simon-svn: putty: simon
Commits to Tartarus CVS repository.
tartarus-commits at lists.tartarus.org
Tue Jul 8 23:22:13 BST 2014
SVN root: svn://svn.tartarus.org/sgt
Changes by: simon
Revision: 10202
Date: 2014-07-08 23:22:12 +0100 (Tue, 08 Jul 2014)
Log message (12 lines):
Work around a timer leak with GTK 2.4.22 on openSUSE 13.1.
Mihkel Ader reports that on that system, timers apparently aren't
getting auto-destroyed when timer_trigger returns FALSE, so the change
in r10181 has caused GTK PuTTY to gradually allocate more and more
timers and consume more and more CPU as they all keep firing.
As far as I can see, this must surely be a bug in GTK 2 (the docs say
that timers _are_ auto-destroyed when their callback returns false),
and it doesn't seem to happen for me with GTK 2.4.23 on Ubuntu 14.04.
However, I'll try to work around it by _explicitly_ destroying each
old timer before we zero out the variable containing its id.
Modified files:
U putty/unix/gtkwin.c
Links:
http://svn.tartarus.org/sgt/?rev=10202&view=rev
http://svn.tartarus.org/sgt/putty/unix/gtkwin.c?rev=10202&r1=10201&r2=10202
More information about the tartarus-commits
mailing list