simon-git: putty (master): Simon Tatham

[Commits to Tartarus CVS repository.]

TL;DR:
  76612e7 Add conditioned-out diagnostics in columns_compute_width.
  769600b Add conditioned-out diagnostics in GTK key_event().
  b8dd15b Stop using abs(unsigned) in X11 time comparison.
  9edf791 Make Columns disregard the preferred width of GtkEntry.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-08-27 19:04:42

commit 76612e772d7712a22b8030363019b24e33be9c3d
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=76612e772d7712a22b8030363019b24e33be9c3d;hp=54dcfb033c13fd56faa077520d425b1704c80fce
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Aug 27 18:32:41 2015 +0100

    Add conditioned-out diagnostics in columns_compute_width.
    
    These are a slightly cleaned-up version of the diagnostics I was using
    to debug the layout problems in the GTK3 config box the other day. In
    particular, if the box comes out far too wide - as I've just found out
    that it also does when I compile the current state of the code against
    OS X GTK3 - these diagnostics should provide enough information to
    figure out which control is the limiting factor.
    
    To enable: make CPPFLAGS="-DCOLUMNS_WIDTH_DIAGNOSTICS"

 unix/gtkcols.c |   29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

commit 769600b226cadd1bd08a21ac8fec59698592dbb8
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=769600b226cadd1bd08a21ac8fec59698592dbb8;hp=76612e772d7712a22b8030363019b24e33be9c3d
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Aug 27 18:35:17 2015 +0100

    Add conditioned-out diagnostics in GTK key_event().
    
    These should dump out all the important parts of the incoming
    GdkEventKey, so that if keys aren't being translated right, it should
    be possible to work out something about why not.
    
    To enable: make CPPFLAGS="-DKEY_EVENT_DIAGNOSTICS"

 unix/gtkwin.c |  128 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 128 insertions(+)

commit b8dd15b8ffd6a9ebdbeceb9db3a3507492780e88
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=b8dd15b8ffd6a9ebdbeceb9db3a3507492780e88;hp=769600b226cadd1bd08a21ac8fec59698592dbb8
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Aug 27 18:39:36 2015 +0100

    Stop using abs(unsigned) in X11 time comparison.
    
    The validation end of XDM-AUTHORIZATION-1 needs to check that two
    time_t values differ by at most XDM_MAXSKEW, which it was doing by
    subtracting them and passing the result to abs(). This provoked a
    warning from OS X's clang, on the reasonable enough basis that the
    value passed to abs was unsigned.
    
    Fixed by using the (well defined) unsigned arithmetic wraparound: to
    check that the mathematical difference of two unsigned numbers is in
    the interval [-k,+k], compute their difference _plus k_ as an
    unsigned, and check the result is in the interval [0,2k] by doing an
    unsigned comparison against 2k.

 doc/udp.but |    4 +++-
 x11fwd.c    |    3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

commit 9edf7910fc0a1c329cc891942b2e1bd66570bc77
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=9edf7910fc0a1c329cc891942b2e1bd66570bc77;hp=b8dd15b8ffd6a9ebdbeceb9db3a3507492780e88
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Aug 27 18:59:24 2015 +0100

    Make Columns disregard the preferred width of GtkEntry.
    
    On OS X GTK, it requests a preferred width that's way too large. I
    think that's because that's based on its max_width_chars rather than
    its width_chars (and I only set the latter). But I don't want to
    actually reduce its max_width_chars, in case (either now or in a
    future version) that causes it to actually refuse to take up all the
    space it's allocated.

 unix/gtkcols.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)