simon-git: putty (master): Simon Tatham

[Commits to Tartarus CVS repository.]

TL;DR:
  45d5aac Set "entry-text-column" on our combo boxes.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-12-06 07:30:40

commit 45d5aacbfa416d4c585539a76c5b046c8f143401
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=45d5aacbfa416d4c585539a76c5b046c8f143401;hp=1659cf3f1455f7e3d9c97a66f90a0cfa914d1ce3
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Dec 6 07:23:59 2015 +0000

    Set "entry-text-column" on our combo boxes.
    
    When we provide an editable text box with a drop-down list of useful
    preset values, such as the one full of character sets in the
    Translation panel, we implement it on GTK 2.4+ as a GtkComboBox
    pointing at a two-column GtkListStore, in which the second column is
    the actual text (the first being a numeric id). Therefore, we need to
    set the "entry-text-column" property to tell GtkComboBox which of
    those columns to look in for the value corresponding to the edit-box
    text.
    
    Thanks to Robert de Bath for spotting the problem and tracing it as
    far as commit 5fa22495c. That commit replaced a widget construction
    call via gtk_combo_box_entry_new_with_model() with one using the newer
    gtk_combo_box_new_with_model_and_entry(), overlooking the fact that
    the former provided the text column number as a parameter, and the
    latter didn't.

 unix/gtkdlg.c |    2 ++
 1 file changed, 2 insertions(+)