simon-git: putty (master): Simon Tatham

[Commits to Tartarus CVS repository.]

TL;DR:
  a181639 Unix Pageant: fix a double-free when adding keys.
  460c45d Unix Pageant: factor out have_controlling_tty().
  75b7ba2 Unix Pageant: implement GUI passphrase prompting.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-05-13 15:35:24

commit a1816395211c7acfa24b0eabfcb5f05ca5fcc074
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=a1816395211c7acfa24b0eabfcb5f05ca5fcc074;hp=c6c23ed84b544661694a74956499506ff53ebc71
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed May 13 13:22:44 2015 +0100

    Unix Pageant: fix a double-free when adding keys.
    
    I had freed the comment string coming back from pageant_add_keyfile,
    but not NULLed out the pointer, so that the cleanup code at the end of
    the function would have freed it again.

 unix/uxpgnt.c |    1 +
 1 file changed, 1 insertion(+)

commit 460c45dd235fae180256c9606df865066f8a791c
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=460c45dd235fae180256c9606df865066f8a791c;hp=a1816395211c7acfa24b0eabfcb5f05ca5fcc074
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed May 13 13:54:15 2015 +0100

    Unix Pageant: factor out have_controlling_tty().
    
    I'm going to want to reuse it when deciding on a passphrase-prompting
    strategy.

 unix/uxpgnt.c |   24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

commit 75b7ba26d3437dc0c89446f1e8d3dd6edb05e1af
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=75b7ba26d3437dc0c89446f1e8d3dd6edb05e1af;hp=460c45dd235fae180256c9606df865066f8a791c
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed May 13 13:55:08 2015 +0100

    Unix Pageant: implement GUI passphrase prompting.
    
    I've written my own analogue of OpenSSH's ssh-askpass. At the moment,
    it's contained inside Pageant proper, though it could easily be
    compiled into a standalone binary as well or instead.
    
    Unlike OpenSSH's version, I don't use a GTK edit box; instead I just
    process key events myself and append them to a buffer. The big
    advantage of doing this is that I can arrange for ^W and ^U to
    function as they do in terminal line editing, i.e. delete a word or
    delete the whole line.
    
    ^W in particular is really valuable when typing a multiple-word
    passphrase unseen. If you feel yourself making the kind of typo in
    which you're not sure if you pressed six keys or just five, you can
    hit ^W and restart just that word, without either having to go right
    back to the beginning or carry on and see if you feel lucky.
    
    A delete-word function would of course be an information leak in even
    an obscured edit box (displaying a blob per character), so instead I
    give a visual acknowledgment of keypresses by a more ad-hoc means: I
    display three lights in the box, and every meaningful keypress turns
    off the currently active one and instead turns on a randomly selected
    one of the others. (So the lit light doesn't even indicate _mod 3_ how
    many keys have been pressed.)

 Recipe        |    4 +-
 unix/gtkask.c |  384 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 unix/uxpgnt.c |   74 +++++++----
 3 files changed, 435 insertions(+), 27 deletions(-)