simon-git: puzzles (master): Simon Tatham

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Wed Oct 21 18:32:16 BST 2015


TL;DR:
  1cf403c Fix array overruns in the new Filling solver pass.

Repository:     git://git.tartarus.org/simon/puzzles.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=puzzles.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-10-21 18:32:16

commit 1cf403ceb81482dea7107a49573d6834c5a650d1
web diff http://tartarus.org/~simon-git/gitweb/?p=puzzles.git;a=commitdiff;h=1cf403ceb81482dea7107a49573d6834c5a650d1;hp=90af15b43ed57a6835091bb1c98227052590b3ea
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Oct 21 18:32:15 2015 +0100

    Fix array overruns in the new Filling solver pass.
    
    Probably because I wrote a couple of loops up to the maximum cell
    value using the non-idiomatic <= for their termination test, I also
    managed to use <= inappropriately for iterating over every cell of the
    grid, leading to a couple of references just off the end of arrays.
    
    Amusingly, it was the Emscripten front end which pointed this out to
    me by actually crashing as a result! Though valgrind found it just
    fine too, once I thought to run that. But it comes to something when
    running your C program in Javascript detects your memory errors :-)

 filling.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list