simon-git: putty (master): Simon Tatham

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Wed Sep 2 19:01:38 BST 2015


TL;DR:
  0de1ac9 Fix assertion failure in xterm mouse tracking.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-09-02 19:01:38

commit 0de1ac95e5fe91e71061120de314b9bd852c2303
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=0de1ac95e5fe91e71061120de314b9bd852c2303;hp=7524da621b1689b3384020cd6d83c990ef86bfa1
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Sep 2 18:56:20 2015 +0100

    Fix assertion failure in xterm mouse tracking.
    
    The original version of the xterm mouse tracking protocol did not
    support character-cell coordinates greater than 223. If term_mouse()
    got one, it would fail to construct an escape sequence for the mouse
    event, and would then call ldisc_send() with a zero-length string -
    which fails an assertion that I added in November (c269dd0135) on the
    occasion of moving ldisc_echoedit_update() into its own function. So
    the corresponding operation before that change would have done a
    gratuitous ldisc_echoedit_update(), which is exactly the sort of thing
    the assertion was there to catch :-)
    
    Later extensions to the mouse tracking protocol support larger
    coordinates anyway (try ESC[?1006h or ESC[?1015h in addition to the
    ESC[?1000h that turns the whole system on in the first place). It's
    only clients that don't use one of those extensions which would have
    had the problem.
    
    Thanks to Mirko Wolle for the report.

 terminal.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)



More information about the tartarus-commits mailing list