simon-git: putty (master): Simon Tatham

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Thu Apr 7 07:55:12 BST 2016


TL;DR:
  c0a57d0 Fix semantics of empty string in mkfiles.pl "!cflags".
  f0f19b6 Add some missing 'const' in version.c's string data.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2016-04-07 07:55:12

commit c0a57d0b9eb38dd291d535d94fa75c360c69a4eb
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=c0a57d0b9eb38dd291d535d94fa75c360c69a4eb;hp=8552f5cb9ab9d0c5a654bef71783bd93d2b42cf2
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Apr 7 07:52:01 2016 +0100

    Fix semantics of empty string in mkfiles.pl "!cflags".
    
    Previously, if you tried to set the special cflags for an object file
    to the empty string, mkfiles.pl would normalise that to the string
    "1". I'm not entirely sure why - that line of code was added without
    explanation in commit 64150a5ef which brought in that directive in the
    first place - but I have to guess that it was left over from some
    earlier design iteration in which I hadn't quite decided whether I was
    going to need a string or a boolean to separate version.o from other
    objects.
    
    Of course, setting an object's cflags to "" is a bit of a weird thing
    to want to do anyway - why not just leave them unset? But in fact I've
    now thought of something useful for it to do: this commit arranges
    that setting cflags="" has the effect (in the 'am' makefile type) of
    separating the object out into its own little automake library but not
    actually giving that library any separate cflags. And the point of
    _that_, in turn, will be that then you can add cflags to it
    _conditionally_ in a "!begin am" snippet, e.g. conditionalised on
    something in configure.

 mkfiles.pl |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

commit f0f19b61477c85ae13fbd540906b6788fdd4b0fd
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=f0f19b61477c85ae13fbd540906b6788fdd4b0fd;hp=c0a57d0b9eb38dd291d535d94fa75c360c69a4eb
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Apr 7 07:52:55 2016 +0100

    Add some missing 'const' in version.c's string data.
    
    I can't believe this codebase is around 20 years old and has had
    multiple giant const-fixing patches, and yet there are _still_ things
    that should have been const for years and aren't.

 putty.h           |    2 +-
 ssh.h             |    2 +-
 version.c         |    4 ++--
 windows/winpgen.c |    2 +-
 windows/winpgnt.c |    2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)



More information about the tartarus-commits mailing list