simon-git: puzzles (master): puzzles.git

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Tue Dec 27 16:30:13 GMT 2016


TL;DR:
  7cae89f Add some missing calls to midend_redraw().

Repository:     https://git.tartarus.org/simon/puzzles.git
On the web:     https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: master
Committer:      puzzles.git
Date:           2016-12-27 16:30:13

commit 7cae89fb4b22c305b3fd98b4e1be065ad527a9f7
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=7cae89fb4b22c305b3fd98b4e1be065ad527a9f7;hp=0b348877e22930bd76c6f00d8d634f7669cd1acb
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Dec 27 16:13:01 2016 +0000

    Add some missing calls to midend_redraw().
    
    I've just noticed that the GTK game window was not being redrawn when
    changing between puzzle modes that don't involve a window resize - by
    selecting a preset from the Type menu (e.g. changing between different
    12x12 settings in Flood) or via the Custom menu.
    
    It looks as if the bug was introduced in commit 8dfe5cec3, which
    suggests that it was a side effect of the switch from
    gtk_window_resize_to_geometry to plain gtk_window_resize. My guess is
    that the implementation of the former function inside GTK might have
    happened to trigger an unconditional window resize, while the latter
    took the shortcut of doing nothing if the window was already the right
    size; hence, resize_fe() would have been reliably generating a redraw
    event without me having to ask for one, but now it doesn't, so I have
    to trigger one myself any time I've just called resize_fe.

 gtk.c | 3 +++
 1 file changed, 3 insertions(+)



More information about the tartarus-commits mailing list