simon-git: puzzles (master): Simon Tatham
Commits to Tartarus CVS repository.
tartarus-commits at lists.tartarus.org
Sun Jan 3 09:51:32 GMT 2016
TL;DR:
55683ab Fix a valgrind warning in the Keen DIFF_HARD solver code.
Repository: git://git.tartarus.org/simon/puzzles.git
On the web: http://tartarus.org/~simon-git/gitweb/?p=puzzles.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2016-01-03 09:51:32
commit 55683abd97f94286982924ff0fecd03044e82bed
web diff http://tartarus.org/~simon-git/gitweb/?p=puzzles.git;a=commitdiff;h=55683abd97f94286982924ff0fecd03044e82bed;hp=ff91d2d78d96441893acd1b1099726346e7f84cf
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Jan 3 09:51:15 2016 +0000
Fix a valgrind warning in the Keen DIFF_HARD solver code.
The solver's array ctx->iscratch[] is used for a completely different
purpose in the DIFF_HARD code, compared to what it's used for in
DIFF_EASY and DIFF_NORMAL. In particular, a different number of
elements of the array are used - but the code which sets up the array
was not correctly initialising all of them.
I was also unable to find any clear comment that even explained _that_
the purpose of the array was entirely different between the two cases,
let alone explaining _what_ the two purposes were. So I've written
some comments as part of this commit, which should make things a bit
less confusing next time. (Though not much, I admit.)
keen.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 44 insertions(+), 1 deletion(-)
More information about the tartarus-commits
mailing list