simon-git: putty (master): Simon Tatham

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Tue Mar 29 13:57:29 BST 2016


TL;DR:
  ad87950 Rework window geometry to avoid using geometry_widget.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2016-03-29 13:57:29

commit ad879505399eeeeb1f279f10a2176d92c842c465
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=ad879505399eeeeb1f279f10a2176d92c842c465;hp=df93419ae5dcc57e2fd051f54c564849e1fb3789
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Mar 29 13:42:54 2016 +0100

    Rework window geometry to avoid using geometry_widget.
    
    Partly this is because the geometry_widget functionality is going away
    in a later version of GTK3, so sooner or later we'll need not to be
    using it anyway. But also, it turns out that GTK 3's geometry
    calculations have the unfortunate effect of setting the window's base
    and min heights to values that are not congruent mod height_increment
    (because the former is the value we gave, but the latter is based on
    the minimum height of the scrollbar), which confuses at least one
    window manager (xfwm4) and causes the window to be created one row too
    small.
    
    So I've redone all the geometry computations my own way, based on the
    knowledge that the only widgets visible in the top-level window are
    the drawing area and the scrollbar and I know how both of those
    behave, and taking care to keep base_height and min_height congruent
    to avoid that xfwm4 bug.

 unix/gtkwin.c |  116 ++++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 85 insertions(+), 31 deletions(-)



More information about the tartarus-commits mailing list