simon-git: putty (master): putty.git

[Commits to Tartarus hosted VCS]

TL;DR:
  13d52fc Fix an EOF-testing goof in winhandl.c.
  8923a1b Move declaration of frontend_is_utf8 into putty.h.
  7acc0a2 Missing initialisation in winsecur.c.
  095072f A bunch of further warning fixes in the Windows code.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      putty.git
Date:           2017-02-03 19:39:11

commit 13d52fcb036ba52db597f49ea291cd6dd4105f43
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=13d52fcb036ba52db597f49ea291cd6dd4105f43;hp=f6c1c8819b5d90a97124b62ee07b0e06d6bbb6c3
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Feb 3 19:33:50 2017 +0000

    Fix an EOF-testing goof in winhandl.c.
    
    I was having a play with clang's MSVC compatibility mode, just to see
    how much of PuTTY it could compile, and one of its warnings pointed
    out this error which must have crept in when I was changing the EOF
    flags in winhandl.c from booleans to three-state enums - I left the !
    on the front of what was previously an if (!thing) and needed to turn
    into if (thing == EOF_NO).

 windows/winhandl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 8923a1b488b69e943d241aa3f0373ed3d5f8110e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=8923a1b488b69e943d241aa3f0373ed3d5f8110e;hp=13d52fcb036ba52db597f49ea291cd6dd4105f43
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Feb 3 19:35:41 2017 +0000

    Move declaration of frontend_is_utf8 into putty.h.
    
    It's a function that exists on all platforms, not just on Unix - it's
    used in ldisc.c - so it shouldn't have been declared only in unix.h.
    Score another for clang's warnings.

 putty.h     | 1 +
 unix/unix.h | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

commit 7acc0a2aa1377ddd575ab635d364b48fd8686fce
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=7acc0a2aa1377ddd575ab635d364b48fd8686fce;hp=8923a1b488b69e943d241aa3f0373ed3d5f8110e
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Feb 3 19:36:46 2017 +0000

    Missing initialisation in winsecur.c.
    
    We might have returned true from getsids() by mistake, even if
    something had gone wrong. Thanks again, clang.

 windows/winsecur.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 095072fa46b2d7b8beafaddb2f873d2f500a1e10
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=095072fa46b2d7b8beafaddb2f873d2f500a1e10;hp=7acc0a2aa1377ddd575ab635d364b48fd8686fce
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Feb 3 19:37:59 2017 +0000

    A bunch of further warning fixes in the Windows code.
    
    These ones are stylistic rather than potential bugs: mostly signedness
    of char pointers in cases where they clearly aren't going to cause the
    wrong thing to actually happen, and one thing in winsecur.c where
    clang would have preferred an extra pair of braces around some
    initialisers but it's legal with or without. But since some of clang's
    warnings turn out to be quite useful, it seems worth silencing these
    harmless ones so as to be able to see the rest.

 windows/window.c   |  6 +++---
 windows/wingss.c   |  2 +-
 windows/winprint.c |  6 +++---
 windows/winsecur.c |  4 ++--
 windows/winstore.c | 21 +++++++++++----------
 5 files changed, 20 insertions(+), 19 deletions(-)