simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Wed Feb 22 22:18:45 GMT 2017


TL;DR:
  86b604d uxproxy: fix write error handling on outgoing pipe.
  51732fa Windows handle sockets: fix error handling in sentdata().
  3f29d93 Unix buildinfo: stop saying 'GTK' in pure CLI utilities.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2017-02-22 22:18:45

commit 86b604dd65679d983c06012b377e41c927da3cd6
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=86b604dd65679d983c06012b377e41c927da3cd6;hp=9ce982622f9ab07b85cbb06d06f53b71fb9558a9
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Feb 22 21:51:03 2017 +0000

    uxproxy: fix write error handling on outgoing pipe.
    
    Jacob pointed out the other day that the call to logevent with NULL
    frontend handle can't possibly work, and the comment next to it saying
    that it can is an outright lie (probably thoughtlessly copied from
    some part of the Windows front end, where it actually would be true).
    Furthermore, even if that logevent call didn't dereference NULL and
    segfault, the followup call to fatalbox() would be inappropriate,
    since proxied connections need not be the primary network connection
    of the whole process.
    
    Rewritten as a call to plug_closing, which is the proper channel
    through which to report errors on an individual socket or equivalent.

 unix/uxproxy.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

commit 51732faeb913527f3373e3c77bf66ca414e5bab6
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=51732faeb913527f3373e3c77bf66ca414e5bab6;hp=86b604dd65679d983c06012b377e41c927da3cd6
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Feb 22 21:57:04 2017 +0000

    Windows handle sockets: fix error handling in sentdata().
    
    In the sentdata callback function given to handle_output_new, the
    'new_backlog' parameter can be negative, and if so, it represents a
    Windows error code and not a backlog size at all. handle_sentdata was
    not checking for this before passing it on to plug_sent.

 windows/winhsock.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

commit 3f29d939ee6d20789eff0fb779592f64fc4bf892
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=3f29d939ee6d20789eff0fb779592f64fc4bf892;hp=51732faeb913527f3373e3c77bf66ca414e5bab6
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Feb 22 22:10:05 2017 +0000

    Unix buildinfo: stop saying 'GTK' in pure CLI utilities.
    
    Unix PSCP, PSFTP, Plink and PuTTYgen now just report their build
    platform as '64-bit Unix' or '32-bit Unix', without mentioning
    irrelevant details of what flavour of GTK the other tools in the suite
    might have been built against.
    
    (In particular, they now won't imply anything outright untrue if there
    was no GTK present at build time at all!)

 cmdgen.c       |  3 +++
 fuzzterm.c     |  3 +++
 testbn.c       |  3 +++
 unix/gtkapp.c  |  2 ++
 unix/gtkask.c  |  2 ++
 unix/gtkmain.c |  2 ++
 unix/unix.h    | 14 +++++++++++---
 unix/uxplink.c |  2 ++
 unix/uxsftp.c  |  2 ++
 9 files changed, 30 insertions(+), 3 deletions(-)



More information about the tartarus-commits mailing list