simon-git: putty (master): putty.git
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Tue Jan 10 22:28:10 GMT 2017
TL;DR:
a76de87 x11font: fix handling of high-bit-set SBCS characters.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer: putty.git
Date: 2017-01-10 22:28:10
commit a76de8774bfcbbd54b6a0fa8d7815c6c0b20dfac
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=a76de8774bfcbbd54b6a0fa8d7815c6c0b20dfac;hp=225186cad26aa360f2fec9c5bfebcc960d234344
Author: Simon Tatham <anakin at pobox.com>
Date: Tue Jan 10 22:22:49 2017 +0000
x11font: fix handling of high-bit-set SBCS characters.
I had mistakenly pulled a 'char' value out of a string and passed it
to x11_font_has_glyph and x11_char_struct, each of which takes its two
index bytes as int-typed parameters. But if chars are signed, that
turns high-bit-set characters into out-of-range array indices. Oops.
The range checks in x11_char_struct prevented that from causing any
problem worse than refusal to display any affected glyph. Even so,
that's not particularly helpful. Fixed by changing the index byte
parameters to unsigned char type.
unix/gtkfont.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
More information about the tartarus-commits
mailing list