simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  f0126dd Set ssh->mainchan->type earlier.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2017-07-17 21:05:00

commit f0126dd198358f2ae351bc49e8edf056c3ce2c6e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=f0126dd198358f2ae351bc49e8edf056c3ce2c6e;hp=25683f0f3d5a654c1e2a8e1d43dca3778a77e7de
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Jul 17 20:57:07 2017 +0100

    Set ssh->mainchan->type earlier.
    
    A user reported a nonsensical assertion failure (claiming that
    ssh->version != 2) which suggested that a channel had somehow outlived
    its parent Ssh in the situation where the opening of the main session
    channel is rejected by the server. Checking with valgrind suggested
    that things start to go wrong at the point where we free the half-set-
    up ssh->mainchan before having filled in its type field, so that the
    switch in ssh_channel_close_local() picks an arbitrary wrong action.
    
    I haven't reproduced the same failure the user reported, but with this
    change, Unix plink is now valgrind-clean in that failure situation.

 ssh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)