simon-git: putty (master): Ben Harris

[Commits to Tartarus hosted VCS]

TL;DR:
  95f8122 uxplink: remove the "connopen" variable.
  30cdaa7 unix: make select_result() return void.
  d56496c unix: make uxsel callback functions return void.
  f65c316 winplink: remove "connopen" variable.
  70e2e14 windows: Remove spurious redeclarations of select_result().
  a2fb1d9 windows: Make select_result() return void.
  0d9c7d8 Don't treat plug_closing() and plug_receive() as returning backlog.
  0d57b8a Make plug receive and closing functions return void instead of int.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Ben Harris <bjh21 at bjh21.me.uk>
Date:           2017-05-14 17:00:35

commit 95f81227a29a79eeafb6395db159c376cafd6bc2
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=95f81227a29a79eeafb6395db159c376cafd6bc2;hp=93931b0a568c8f39801ffcb0c67cc001dac4f9b3
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon May 30 20:40:29 2016 +0100

    uxplink: remove the "connopen" variable.
    
    It had the constant value 1 everywhere that it was read.

 unix/uxplink.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

commit 30cdaa7ca8bfa03d90e170c2260d71a5819996b2
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=30cdaa7ca8bfa03d90e170c2260d71a5819996b2;hp=95f81227a29a79eeafb6395db159c376cafd6bc2
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon May 30 22:37:32 2016 +0100

    unix: make select_result() return void.
    
    Nothing was using its return value anyway.

 unix/unix.h  | 2 +-
 unix/uxsel.c | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

commit d56496c31c85767b805f261f01fc87cc8a468dec
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d56496c31c85767b805f261f01fc87cc8a468dec;hp=30cdaa7ca8bfa03d90e170c2260d71a5819996b2
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon May 30 22:52:30 2016 +0100

    unix: make uxsel callback functions return void.
    
    Nothing used their return values anyway.  At least, not after the
    previous commit.

 unix/unix.h     |  2 +-
 unix/uxagentc.c |  7 +++----
 unix/uxnet.c    | 24 +++++++++++-------------
 unix/uxproxy.c  | 15 ++++++---------
 unix/uxpty.c    | 13 ++++---------
 unix/uxser.c    | 12 +++++-------
 6 files changed, 30 insertions(+), 43 deletions(-)

commit f65c31667e0dee8d416df41dac66198a80c3314b
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=f65c31667e0dee8d416df41dac66198a80c3314b;hp=d56496c31c85767b805f261f01fc87cc8a468dec
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon May 30 20:47:04 2016 +0100

    winplink: remove "connopen" variable.
    
    It's redundant with back->connected(): only the SSH backend has a
    receive function that can ever return 0, and whenever ssh_receive
    returns 0 it has called ssh_do_close, which will cause future calls
    to ssh_connected also to return 0.  Similarly, all backend closing
    functions ensure that future calls to their connected function will
    return 0.

 windows/winplink.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

commit 70e2e140f054f5cd894d0fd7f2c31a23cd7f7377
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=70e2e140f054f5cd894d0fd7f2c31a23cd7f7377;hp=f65c31667e0dee8d416df41dac66198a80c3314b
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Thu Jun 2 22:37:36 2016 +0100

    windows: Remove spurious redeclarations of select_result().

 windows/winplink.c | 1 -
 windows/winsftp.c  | 2 --
 2 files changed, 3 deletions(-)

commit a2fb1d96ef4660f94c2bed6cad1749c10013d351
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=a2fb1d96ef4660f94c2bed6cad1749c10013d351;hp=70e2e140f054f5cd894d0fd7f2c31a23cd7f7377
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Thu Jun 2 22:38:36 2016 +0100

    windows: Make select_result() return void.
    
    Nothing now uses its return value anyway.

 windows/winnet.c   | 33 +++++++++++++--------------------
 windows/winstuff.h |  2 +-
 2 files changed, 14 insertions(+), 21 deletions(-)

commit 0d9c7d82e8506d9b6da557cfaf8a08bc3bfeb299
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=0d9c7d82e8506d9b6da557cfaf8a08bc3bfeb299;hp=a2fb1d96ef4660f94c2bed6cad1749c10013d351
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Sat Jun 4 15:42:06 2016 +0100

    Don't treat plug_closing() and plug_receive() as returning backlog.
    
    plug_receive() and plug_closing() return 0 or 1 depending on whether
    they think the main connection has closed.  It is not appropriate, as
    handle_gotdata and handle_socket_unfreeze did, to treat them as
    returning a backlog.  In fact, plugs are unusual in PuTTY in not
    reporting a backlog, but just calling into the socket to freeze and
    unfreeze it as required.

 windows/winhsock.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

commit 0d57b8a4d9c8f487c6a8806384cb2c485161d19c
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=0d57b8a4d9c8f487c6a8806384cb2c485161d19c;hp=0d9c7d82e8506d9b6da557cfaf8a08bc3bfeb299
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Thu Jun 2 23:03:24 2016 +0100

    Make plug receive and closing functions return void instead of int.
    
    Nothing was paying attention to their return values any more anyway.

 network.h     |  4 ++--
 pageant.c     | 18 ++++++++----------
 portfwd.c     | 25 ++++++++++---------------
 proxy.c       | 41 +++++++++++++++++++++--------------------
 raw.c         |  8 +++-----
 rlogin.c      |  8 +++-----
 ssh.c         |  9 +++------
 sshshare.c    | 25 +++++++++++--------------
 telnet.c      |  8 +++-----
 unix/uxpgnt.c |  7 +++----
 x11fwd.c      | 18 ++++++------------
 11 files changed, 73 insertions(+), 98 deletions(-)