simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Tue Sep 5 20:26:20 BST 2017


TL;DR:
  4634cd4 Avoid zero-length ldisc_send() in terminal.c.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2017-09-05 20:26:20

commit 4634cd47f75e74a697840fb32f18edb7f1cf41da
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=4634cd47f75e74a697840fb32f18edb7f1cf41da;hp=a459fc58e844a2152cedb068d5b552bd3aabd654
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Sep 5 20:14:33 2017 +0100

    Avoid zero-length ldisc_send() in terminal.c.
    
    A user reports that a remote window title query, if the window title
    is empty or if the option to return it is disabled, fails the
    assertion in ldisc_send that I introduced as part of commit c269dd013
    to catch any lingering uses of ldisc_send with length 0 that should
    have turned into ldisc_echoedit_update. Added a check for len > 0
    guarding that ldisc_send call, and likewise at one or two others I
    noticed on my way here.
    
    (Probably at some point I should decide that the period of smoking out
    lingering old-style ldisc_send(0) calls is over, and declare it safe
    to remove that assertion again and get rid of all the cumbersome
    safety checks at call sites like these ones. But not quite yet.)

 terminal.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)



More information about the tartarus-commits mailing list