simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  6c4d3cb Better file-existence test on Windows.
  b26bd60 Avoid logging zero-length strings of outgoing raw data.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-02-07 21:01:48

commit 6c4d3cb8f33a4e5db49c4fd40c4363876b6f505c
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=6c4d3cb8f33a4e5db49c4fd40c4363876b6f505c;hp=b4fde270c6cbf2fc30a414428e9c7b7a3e557cc7
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Feb 7 20:05:32 2018 +0000

    Better file-existence test on Windows.
    
    Windows, annoyingly, doesn't seem to have any bit flag in
    GetFileAttributes which distinguishes a regular file (which can be
    truncated destructively) from a named pipe (which can't).
    
    Fortunately, I'm saved from needing one by the policy I came up with
    in the previous commit, in which I don't bother to ask about
    truncating a file if it already has zero length, because it would make
    no difference anyway. Named pipes do show up as zero-length in
    GetFileAttributesEx, so they get treated like zero-length regular
    files by this change and it's all good.

 windows/winmisc.c | 32 +++++++++++++++++++++++++++-----
 1 file changed, 27 insertions(+), 5 deletions(-)

commit b26bd60df9d172f0ee9f83ee3c1ce42709cb33ee
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=b26bd60df9d172f0ee9f83ee3c1ce42709cb33ee;hp=6c4d3cb8f33a4e5db49c4fd40c4363876b6f505c
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Feb 7 19:56:28 2018 +0000

    Avoid logging zero-length strings of outgoing raw data.
    
    In the 'SSH packets + raw data' logging mode, one of these occurs
    immediately after the initial key exchange, at the point where the
    transport routine releases any queued higher-layer packets that had
    been waiting for KEX to complete. Of course, in the initial KEX there
    are never any of those, so we do a zero-length s_write(), which is
    harmless but has the side effect of a zero-length raw-data log entry.

 ssh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)