simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Tue Feb 13 19:47:38 GMT 2018


TL;DR:
  31a2017 Add missing casts in dupcat().

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-02-13 19:47:38

commit 31a2017af5fd3c279fce362469a5894882db89c6
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=31a2017af5fd3c279fce362469a5894882db89c6;hp=3447047594249fbd0db517b1927b1d59657b2963
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Feb 13 19:45:54 2018 +0000

    Add missing casts in dupcat().
    
    Ahem. I _spotted_ this in code review, and forgot to make the change
    before pushing!
    
    Because it's legitimate for a C implementation to define 'NULL' so
    that it expands to just 0, it follows that if you use NULL in a
    variadic argument list where the callee will expect to extract a
    pointer, you run the risk of putting an int-sized rather than
    pointer-sized argument on the list and causing the consumer to get out
    of sync. So you have to add an explicit cast.

 unix/gtkdlg.c    | 2 +-
 windows/windlg.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list