simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Fri Jun 15 19:11:32 BST 2018


TL;DR:
  d4304f1 Fix cut and paste goof in SSH-2 compression support.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-06-15 19:11:32

commit d4304f1b7b3f5e4c02f373977f9f7fe172d4f5fd
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d4304f1b7b3f5e4c02f373977f9f7fe172d4f5fd;hp=ba5e56cd1b448ac7d97e2d8d7cb9eafab66a45b9
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Jun 15 19:08:05 2018 +0100

    Fix cut and paste goof in SSH-2 compression support.
    
    The new SSH-2 BPP has two functions ssh2_bpp_new_outgoing_crypto and
    ssh2_bpp_new_incoming_crypto, which (due to general symmetry) are
    _almost_ identical, except that the code that sets up the compression
    context in the two directions has to call compress_init in the former
    and decompress_init in the latter.
    
    Except that it called compress_init in both, so compression in SSH-2
    has been completely broken for a week. How embarrassing. I _remember_
    thinking that I'd better make sure to change that one call between the
    two, but apparently it fell out of my head before I committed.

 ssh2bpp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)



More information about the tartarus-commits mailing list