simon-git: spigot (master): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Wed Mar 21 22:41:57 GMT 2018
TL;DR:
5180952 GammaResidualBase: convert old printfs into dprint.
0b37604 Turn some assertions into the new internal_fault().
Repository: https://git.tartarus.org/simon/spigot.git
On the web: https://git.tartarus.org/?p=simon/spigot.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2018-03-21 22:41:57
commit 5180952793e7d7b6057e16f03494a238e68a2c8d
web diff https://git.tartarus.org/?p=simon/spigot.git;a=commitdiff;h=5180952793e7d7b6057e16f03494a238e68a2c8d;hp=716c828ae4e2e5da10af3c28c5df2bfd07ebb7fd
Author: Simon Tatham <anakin at pobox.com>
Date: Wed Mar 21 22:32:37 2018 +0000
GammaResidualBase: convert old printfs into dprint.
I spotted these commented-out diagnostics while I was doing my trawl
of the spigot code a couple of days ago looking for refinement
failures. They date from before I introduced the sensible debugging
system, and ought to have been converted into it long since. Now they
have been.
gamma.cpp | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
commit 0b376041a4687bd3f9a2a4142b9a8b2f743d9b9f
web diff https://git.tartarus.org/?p=simon/spigot.git;a=commitdiff;h=0b376041a4687bd3f9a2a4142b9a8b2f743d9b9f;hp=5180952793e7d7b6057e16f03494a238e68a2c8d
Author: Simon Tatham <anakin at pobox.com>
Date: Wed Mar 21 22:34:07 2018 +0000
Turn some assertions into the new internal_fault().
I've chosen which asserts to convert in a somewhat ad-hoc fashion. My
vague idea was that the most important place to give proper new-style
internal faults was when one module in the code is receiving bogus
data from a source that could be in multiple other modules, so that it
would be possible to isolate the debug ids of the failing classes and
trace _which_ possible source fed it the bad data. By contrast, an
assertion that claims a consistency property that should have been
established 10 lines earlier in the same function doesn't need that
same level of traceability. But I probably haven't followed that
principle in a very consistent way even in this commit.
arithmetic.cpp | 1 -
hypergeom.cpp | 18 ++++++++++++------
lambertw.cpp | 1 -
misc.cpp | 1 -
monotone.cpp | 8 ++++----
noexcept.cpp | 1 -
spigot.cpp | 26 +++++++++++++++-----------
unary.cpp | 1 -
8 files changed, 31 insertions(+), 26 deletions(-)
More information about the tartarus-commits
mailing list