simon-git: putty (master): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Tue Mar 27 23:11:05 BST 2018
TL;DR:
d6338c2 Fix mishandling of IV in AES-NI CBC decryption.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2018-03-27 23:11:05
commit d6338c22c32b9f55b71ace80f993bbb8f8c1aa6d
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d6338c22c32b9f55b71ace80f993bbb8f8c1aa6d;hp=c67389e1fbe64e778634c6332449dce3fd302671
Author: Simon Tatham <anakin at pobox.com>
Date: Tue Mar 27 23:05:07 2018 +0100
Fix mishandling of IV in AES-NI CBC decryption.
A user reported that the new hardware AES implementation wasn't
working, and sent an event log suggesting that it was being run in CBC
mode - which is unusual enough these days that that may well have been
its first test.
I wasn't looking forward to debugging the actual AES intrinsics code,
but fortunately, I didn't have to, because an eyeball review spotted a
nice simple error in the CBC decrypt function in which the wrong local
variable was being stored into the IV variable on exit from the
function. Testing against a local CBC-only server reproduced the
reported failure and suggested that this fixed it.
sshaes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
More information about the tartarus-commits
mailing list