simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Thu May 17 19:48:40 BST 2018


TL;DR:
  14a69dc do_ssh1_login: make 'cookie' a coroutine variable.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-05-17 19:48:40

commit 14a69dc632868b2bc053bf19c719b4f1d3153a97
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=14a69dc632868b2bc053bf19c719b4f1d3153a97;hp=d68a772bf7fd3c15c5b0a8ed1db8203a0902f67f
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu May 17 19:41:25 2018 +0100

    do_ssh1_login: make 'cookie' a coroutine variable.
    
    Previously it was local, which _mostly_ worked, except that if the SSH
    host key needed verifying via a non-modal dialog box, there could be a
    crReturn in between writing it and reading it.
    
    It's pretty tempting to suggest that because nobody has noticed this
    before, SSH-1 can't be needed any more! But actually I suspect the
    intervening crReturn has only appeared since the last release,
    probably around November when I was messing about with GTK dialog box
    modality. (I observed the problem just now on the GTK build, while
    trying to check that a completely different set of changes hadn't
    broken SSH-1.)

 ssh.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)



More information about the tartarus-commits mailing list