simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Mon Nov 12 20:32:18 GMT 2018


TL;DR:
  f9f5a617 Stop setting mc->eof_sent if we haven't.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-11-12 20:32:18

commit f9f5a617b254d5c4cdfc630fae6ff329af86a39c
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=f9f5a617b254d5c4cdfc630fae6ff329af86a39c;hp=d2f79e2544a7354d614d4ff00c7a0d603c98133b
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Nov 12 20:27:25 2018 +0000

    Stop setting mc->eof_sent if we haven't.
    
    Looks as if I introduced this bug in commit 431f92ade, when I moved
    mainchan out into its own source file: the previous version of
    mainchan_send_eof conditionalised the setting of mc->eof_sent in the
    same if statement that actually sent the EOF, but somehow, in the new
    version, only one of those operations was inside the if.
    
    The effect is that in plink -nc mode, if the server sends EOF first,
    the client stops listening to standard input at its own end, so it
    never knows when to send EOF back and clean things up.

 mainchan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list