simon-git: bob (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  a159e66 bob-deliver: fix PE Authenticode normalisation.

Repository:     https://git.tartarus.org/simon/bob.git
On the web:     https://git.tartarus.org/?p=simon/bob.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-11-14 20:18:12

commit a159e66a14e8b8f47141e7b6ca7050ea263b7886
web diff https://git.tartarus.org/?p=simon/bob.git;a=commitdiff;h=a159e66a14e8b8f47141e7b6ca7050ea263b7886;hp=6688f34e8899a7f9c5288533b984f614af3155fd
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Nov 14 20:18:01 2018 +0000

    bob-deliver: fix PE Authenticode normalisation.
    
    When we compare two Windows PE binaries, we strip off the certificate
    table containing each one's Authenticode signature (if any). We also
    blank out the entry in the image data directory that _points_ to the
    certificate table, just in case that too had different data in it.
    
    Except we don't - we were accidentally blanking out the entry pointing
    to the _resource_ table, not the certificate table, apparently because
    I just wrote the wrong pair of offsets in the code. So when I changed
    certificates yesterday to one which happened to be a different size, I
    got a big pile of bob-deliver failure emails this morning because all
    my signed binaries now differ in the accidentally-not-actually-blanked
    size field of the certificate table entry in the data directory.

 bob-deliver | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)