simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sat Oct 13 17:27:07 BST 2018


TL;DR:
  1986ee2d Add missing pq_pop when handling SSH_MSG_DISCONNECT.
  e966df07 Avoid Event Log entries with newlines in.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-10-13 17:27:07

commit 1986ee2d9ce1f29bbb9a6d0d41ef07d185213eac
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=1986ee2d9ce1f29bbb9a6d0d41ef07d185213eac;hp=554e8f3991e2f74cc43d5f65b3e6e3b740b323c8
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 13 17:16:07 2018 +0100

    Add missing pq_pop when handling SSH_MSG_DISCONNECT.
    
    Somehow I managed to leave that line out in both SSH-1 and SSH-2's
    functions for handling DISCONNECT, IGNORE and DEBUG, and in both
    cases, only for DISCONNECT. Oops.

 ssh1login.c     | 1 +
 ssh2transport.c | 1 +
 2 files changed, 2 insertions(+)

commit e966df071cba720318a3b87d4be38b41edfba7a6
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=e966df071cba720318a3b87d4be38b41edfba7a6;hp=1986ee2d9ce1f29bbb9a6d0d41ef07d185213eac
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Oct 13 17:23:29 2018 +0100

    Avoid Event Log entries with newlines in.
    
    When logging an SSH_MSG_DISCONNECT, the log message has newlines in,
    because it's also displayed in the GUI dialog box or on Plink's
    standard error, where that makes some sense. But in the Event Log, all
    messages should be one-liners: anything else makes the GUI list boxes
    go weird, and also breaks convenient parsability of packet lot files.
    
    So we turn newlines into spaces for Event Log purposes, which is
    conveniently easy now that Event Log entries always go through
    logging.c first.

 logging.c | 40 +++++++++++++++++++++++++++++++++-------
 1 file changed, 33 insertions(+), 7 deletions(-)



More information about the tartarus-commits mailing list