simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  5f036136 Improve Uppity's online help and command-line errors.
  c9e61182 Uppity: add challenge-response auth methods.
  76a32c51 Fix two bugs in SSH-1 TIS and CryptoCard auth.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-10-22 20:39:33

commit 5f03613614a86a32dfd50e393dedd5d041be6709
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=5f03613614a86a32dfd50e393dedd5d041be6709;hp=1806b71241ccce5628a9a9090d5986075eaf9584
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Oct 22 20:17:47 2018 +0100

    Improve Uppity's online help and command-line errors.
    
    We now show the --help output if invoked with no arguments, and the
    help text also includes a big safety warning in the hope of stopping
    anyone from mistaking this for a _secure_ SSH server implementation.
    
    While I'm here, the errors now all use appname[] in place of
    constantly repeating the program name. (Not because I anticipate a
    change right now, but if nothing else, it makes things easier moving
    errors out into shared source files or between applications.)

 unix/uxserver.c | 85 +++++++++++++++++++++++++++++++++++++--------------------
 1 file changed, 55 insertions(+), 30 deletions(-)

commit c9e6118246fd0ded8adff97245bcef5df0616f87
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c9e6118246fd0ded8adff97245bcef5df0616f87;hp=5f03613614a86a32dfd50e393dedd5d041be6709
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Oct 22 20:32:58 2018 +0100

    Uppity: add challenge-response auth methods.
    
    This adds the server side of the SSH-2 keyboard-interactive protocol,
    and the pair of very similar SSH-1 methods AUTH_TIS and AUTH_CCARD
    (which basically differ only in message numbers, and each involve a
    single challenge from the server and a response from the user).

 ssh1login-server.c    | 46 ++++++++++++++++++++++++++++-
 ssh2userauth-server.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++
 sshserver.h           | 28 ++++++++++++++++++
 unix/uxserver.c       | 64 +++++++++++++++++++++++++++++++++++++++-
 4 files changed, 217 insertions(+), 2 deletions(-)

commit 76a32c514c1f8be6f117f86f26aba93e13147086
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=76a32c514c1f8be6f117f86f26aba93e13147086;hp=c9e6118246fd0ded8adff97245bcef5df0616f87
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Oct 22 20:34:17 2018 +0100

    Fix two bugs in SSH-1 TIS and CryptoCard auth.
    
    Firstly, these protocols had a display heuristic - credited to OpenSSH
    in the comments - in which, if the challenge string contained a
    newline, it was supposed to be printed with "Response: " on the next
    line, whereas if it didn't, it would be taken as a prompt in its own
    right. In fact, I had got the sense of memchr backwards, so each
    behaviour was applying in the opposite case.
    
    Secondly, apparently I'd never before tested against a server that
    offered _both_ those methods, because when I tried it against Uppity
    just now, I found that the setup and challenge phases for both methods
    ran in immediate succession before prompting the user, which confused
    the server completely. This is exactly why I wanted to have a server
    implementation of everything PuTTY is supposed to speak the client
    side of!

 ssh1login.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)