simon-git: filter (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sat Sep 15 23:37:46 BST 2018


TL;DR:
  e3f1937 Change defn of _XOPEN_SOURCE to at least 500.
  f96e1aa Add an error check for ptsname.
  2aa632b Squash compiler warning for write() in signal handlers.

Repository:     https://git.tartarus.org/simon/filter.git
On the web:     https://git.tartarus.org/?p=simon/filter.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-09-15 23:37:46

commit e3f1937e00bb9a64012f094a6bc526e49287ffbf
web diff https://git.tartarus.org/?p=simon/filter.git;a=commitdiff;h=e3f1937e00bb9a64012f094a6bc526e49287ffbf;hp=4df13f4c4592e4de0fe53cbabf806597c8e9746a
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Sep 12 16:59:08 2018 +0100

    Change defn of _XOPEN_SOURCE to at least 500.
    
    Without this, Ubuntu 18.04's stdlib.h won't define the pty functions
    (grantpt, unlockpt etc), so they get implicitly declared as returning
    int, which goes horribly wrong when the actual pointer returned from
    ptsname doesn't fit in an int.

 pty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit f96e1aa59ef336df0f4fe708b5e71c86caafa766
web diff https://git.tartarus.org/?p=simon/filter.git;a=commitdiff;h=f96e1aa59ef336df0f4fe708b5e71c86caafa766;hp=e3f1937e00bb9a64012f094a6bc526e49287ffbf
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Sep 12 17:00:04 2018 +0100

    Add an error check for ptsname.
    
    Just in case it returns NULL, we should report that usefully rather
    than proceeding to dereference it.
    
    (I noticed this while debugging the problem in the previous commit,
    though in fact the pointer _wasn't_ NULL.)

 pty.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

commit 2aa632b0b046db4c49d8f93b86fe1f06e90fbfd4
web diff https://git.tartarus.org/?p=simon/filter.git;a=commitdiff;h=2aa632b0b046db4c49d8f93b86fe1f06e90fbfd4;hp=f96e1aa59ef336df0f4fe708b5e71c86caafa766
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Sep 12 17:03:12 2018 +0100

    Squash compiler warning for write() in signal handlers.
    
    We don't actually want to do anything with the error, but gcc
    complains if we haven't at least tested it in _some_ way.

 main.c | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list