simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  91a624fb sshaes.c: add some missing clang target attributes.
  e71798a2 Fix copy-paste error in sshdes.c.
  e1b52ae7 Remove duplicate typedef of AESContext.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-09-20 23:48:48

commit 91a624fb70230a885656e74c89865270b27c9de9
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=91a624fb70230a885656e74c89865270b27c9de9;hp=93f2df9b837194e678449947d8cf73517e87165c
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Sep 20 16:58:43 2018 +0100

    sshaes.c: add some missing clang target attributes.
    
    The helper functions mm_shuffle_pd_i0 and mm_shuffle_pd_i1 need the
    FUNC_ISA macro (which expands to __attribute__((target("sse4.1,aes")))
    when building with clang) in order to avoid a build error complaining
    that their use of the _mm_shuffle_pd intrinsic is illegal without at
    least sse2.
    
    This build error is new in the recently released clang 7.0.0, compared
    to the svn trunk revision I was previously building with. But it
    certainly seems plausible to me, so I assume there's been some
    pre-release tightening up of the error reporting. In any case, those
    helper functions are only ever called from other functions with the
    same attribute, so it shouldn't cause trouble.

 sshaes.c | 2 ++
 1 file changed, 2 insertions(+)

commit e71798a265a3e425c609dd464039319dfe33318f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=e71798a265a3e425c609dd464039319dfe33318f;hp=91a624fb70230a885656e74c89865270b27c9de9
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Sep 20 17:42:48 2018 +0100

    Fix copy-paste error in sshdes.c.
    
    Apparently introduced just now in commit 6c5cc49e2; thanks to Colin
    Harrison for pointing it out very promptly.
    
    All this FROMFIELD business, helpful as it is, doesn't change the fact
    that you can still absentmindedly cast something to the wrong type if
    you're specifying the type explicitly!

 sshdes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit e1b52ae721ef5b41fb80d88b3e645bee47deadd5
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=e1b52ae721ef5b41fb80d88b3e645bee47deadd5;hp=e71798a265a3e425c609dd464039319dfe33318f
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Sep 20 23:46:45 2018 +0100

    Remove duplicate typedef of AESContext.
    
    Pavel Kryukov points out that ssh.h has this typedef, so sshaes.c
    doesn't have to have it too, and in C89 mode it's an error to have it
    twice.

 sshaes.c | 2 --
 1 file changed, 2 deletions(-)