simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  562cdd4d Fix mishandling of refusal to compress in SSH-1.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-09-21 18:45:30

commit 562cdd4df1b2c741fec90bc80954d76da7a33266
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=562cdd4df1b2c741fec90bc80954d76da7a33266;hp=a19faa452726e1c2c9897834a9139e2a0a0bca04
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Sep 21 18:00:07 2018 +0100

    Fix mishandling of refusal to compress in SSH-1.
    
    I've just noticed that we call ssh1_bpp_start_compression even if the
    server responded to our compression request with SSH1_SMSG_FAILURE!
    
    Also, while I'm here, there's a potential race condition if the server
    were to send an unrelated message (such as SSH1_MSG_IGNORE)
    immediately after the SSH1_SMSG_SUCCESS that indicates compression
    being enabled - the BPP would try to decode the compressed IGNORE
    message before the SUCCESS got to the higher layer that would tell the
    BPP it should have enabled compression. Fixed that by changing the
    method by which we tell the BPP what's going on.

 ssh.c     |  7 ++++---
 ssh1bpp.c | 23 +++++++++++++++++------
 sshbpp.h  |  6 +++++-
 3 files changed, 26 insertions(+), 10 deletions(-)