simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Thu Sep 27 18:16:47 BST 2018


TL;DR:
  c912d093 Handle error messages even before session startup.
  ed0104c2 ssh_closing: distinguish socket errors from EOF.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2018-09-27 18:16:46

commit c912d0936d94c7aacf8698965562743f5f5fa933
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c912d0936d94c7aacf8698965562743f5f5fa933;hp=07313e94661071fa252c1db80806f225d2012995
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Sep 27 17:47:55 2018 +0100

    Handle error messages even before session startup.
    
    I carefully put a flag in the new Ssh structure so that I could tell
    the difference between ssh->base_layer being NULL because it hasn't
    been set up yet, and being NULL because it's been and gone and the
    session is terminated. And did I check that flag in all the error
    routines? I did not. Result: an early socket error, while we're still
    in the verstring BPP, doesn't get reported as an error message and
    doesn't cause the socket to be cleaned up.

 ssh.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

commit ed0104c2feae935271a12af7a9175b81527fe96e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=ed0104c2feae935271a12af7a9175b81527fe96e;hp=c912d0936d94c7aacf8698965562743f5f5fa933
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Sep 27 18:06:16 2018 +0100

    ssh_closing: distinguish socket errors from EOF.
    
    I forgot to check the error_msg parameter at all.

 ssh.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)



More information about the tartarus-commits mailing list